search

brownhci / WebGazer

WebGazer.js: Scalable Webcam EyeTracking Using User Interactions
https://webgazer.cs.brown.edu
Other
3.54k stars 536 forks source link

Fixes #337 : multiple fixes in the code and modernize the style #345

Open Sharcoux opened 5 months ago

Sharcoux commented 5 months ago

This is not 100% complete, as I don't understand very well the build process. I'd need some enlightenment about the www part in order to finish this MR. However, it solves numerous issues reported here along with other ones I noticed on the fly.

Sharcoux commented 2 months ago

I need to make some fixes first. Don't merge anything yet. I'll comment all the changes to justify them

jeffhuang commented 2 months ago

Will do, thank you

Sharcoux commented 1 month ago

I commented the changes, but I would still like to go a bit further with the www folder. I will see if I have the time.

Sharcoux commented 1 week ago

@jeffhuang I finished the complete refacto of the project. I'd be very happy to discuss any change as intensively as needed, but I'm 100% convinced that this structure will be way easier to maintain and evolve in the future. You can test it. I made some small visual changes in the test project and added new buttons, but I can go back to how it was before. I simplified the API a lot for new users of the project. Each function details the available parameters.

I had to switch the src to typescript because of the test project. Importing the types there was too hard otherwise, and securing the calls would have been too hard without any type checks.

jeffhuang commented 1 week ago

Amazing, looking into this and testing...