search

browniebroke / pypackage-template

A project template for Python package with heavy use of Github actions
MIT License
54 stars 13 forks source link

Improvements for copier.yml #497

Open 34j opened 1 year ago

34j commented 1 year ago

Is your feature request related to a problem? Please describe. It's a pain to enter GITHUB_TOKEN, EMAIL and manually create the venv then install packages then run pre-commit.

Describe the solution you'd like Use my jinja2_env to get GITHUB_TOKEN and EMAIL from environment variables and automate. Also create venv automatically by command. The operation must be different depending on the operating system. Example In addition, the copyright year can be automatically entered using jinja2_time. This allows more options to be turned on by default.

Additional context Setting GITHUB_TOKEN as an environment variable is a security concern, but I think it is a win-win to implement as only those who have no concerns can use it. I think I can send a PR for this.

browniebroke commented 1 year ago

You're suggesting a few things here, some I definitely agree with (generating copyright), while others I'm curious to see how they would look like (getting stuff from env variable).

I'm open to see how these would look like, maybe best to submit separate pull requests for them though, not sure I'll accept them all.

34j commented 1 year ago

I think I should not send a PR at this time as it seems kind of difficult to have them merged. Thanks for your prompt replies and feedbacks. Sorry for cluttering up the Issue.