search

browniebroke / pypackage-template

A project template for Python package with heavy use of Github actions
MIT License
53 stars 13 forks source link

feat(ci): enable cache in setup-python #682

Closed 34j closed 1 month ago

34j commented 3 months ago

https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#caching-packages

This may speed up the test slightly. (although it will take longer to install poetry anyway)

browniebroke commented 1 month ago

I haven't found this to make a massive difference in my cases, and the workflow is more complicated (more lines) so not really worth it.

34j commented 1 month ago

This is useful in the rare case of installing a library that takes an inordinate amount of time to install or using many libraries. However I'm also not sure if it should be in the template. (How about commenting it out or making this optional then?)

I would appreciate it if you could take a look at other PRs as well, thank you

browniebroke commented 1 month ago

Thanks for the effort and your patience!