search

brownplt / atom-language-pyret

Pyret language support for Atom
2 stars 1 forks source link

Support for vscode #2

Open SethPoulsen opened 6 years ago

SethPoulsen commented 6 years ago

I've just ported this to work for Visual Studio Code and want to publish it. Would you guys like to have it published on the brownplt page, or should I just do it on my own page?

Any preference of what I name it when I publish to the vscode extension repositories?

Thanks!

SethPoulsen commented 6 years ago

Also, I would like to be able to use the Pyret logo when I publish the extension. Is that possible?

SethPoulsen commented 6 years ago

For now, I've uploaded to here: https://github.com/SethPoulsen/vscode-language-pyret.

jpolitz commented 6 years ago

@SethPoulsen this is awesome! I just started trying out VSCode myself, so this is cool timing for me :-)

I made a repo under brownplt, if you are interested in submitting pull requests there we will happily merge them – what you have looks great, I just downloaded it and tried it out.

https://github.com/brownplt/vscode-language-pyret

Just to double-check, where do you want to use the logo? Is it for icons and stuff in the published extension, in the README, etc?

SethPoulsen commented 6 years ago

@jpolitz Glad you like it!

Yea, it would be cool if the logo would show up with the extension on https://marketplace.visualstudio.com, and if it could show up next to the file names in the file explorer (side panel) in VSCode.

SethPoulsen commented 6 years ago

Also, I can't figure out how to get the new repository to allow me to open a pull request. It seems to be disallowing it since it is completely empty.

jpolitz commented 6 years ago

I added an initial commit to that repo – let me know if that works for you.

We're happy for you to use the logo for this, and thanks for asking first! There's a file called "pyret-icon.png" that we use for favicons that might be especially good for file logo since it avoids trying to scale down the details of the eyepatch:

https://github.com/brownplt/pyret-lang/blob/master/img/pyret-icon.png

Let us know if you have any other questions.

SethPoulsen commented 6 years ago

Its in the vscode extension marketplace! screen shot 2018-03-11 at 12 49 22 am

Should be easy for anyone to install now. Unfortunately, getting the icon to show next to the file name is more complicated, I have submitted an issue here to make it happen: https://github.com/vscode-icons/vscode-icons/issues/1502

JimiC commented 6 years ago

@jpolitz Any chance we can get our 'hooks' (hands) on an SVG version of the logo? We at vscode-icons prefer SVG as they are more digestible!!! 😆

jpolitz commented 6 years ago

Indeed! @JimiC there are svg versions that we use to generate the .pngs at https://github.com/brownplt/pyret-lang/tree/master/img/

JimiC commented 6 years ago

Ah I see. I admit I was too lazy to do a search. My apologies.

shriram commented 6 years ago

Awesome! Now I almost wish I used Visual Studio. (-:

What is the user experience with it, btw?

JimiC commented 6 years ago

Great and it's getting better. But I'm biased so I don't know if my opinion counts.

SethPoulsen commented 6 years ago

Visual Studio Code is awesome. Of course, I wouldn't have bothered making the Pyret extension if it wasn't.

SethPoulsen commented 6 years ago

Shoutout to @JimiC for making the icons happen. Looks awesome! screen shot 2018-03-21 at 5 30 06 pm

jpolitz commented 6 years ago

Cool! For folks seeing this who don't know the details, this is enabled by installing the vscode-icons package (you can just search for "vscode-icons" in the package installer within vscode). I'm new to vscode, but from my reading this is a pretty standard theming package, recommended by the vscode team:

https://code.visualstudio.com/blogs/2016/09/08/icon-themes

Thanks @JimiC and @SethPoulsen !