search

brownplt / code.pyret.org

Website for serving Pyret to folks.
Other
24 stars 45 forks source link

Josh/nolan localfilesave #303

Open j3ven7 opened 5 years ago

j3ven7 commented 5 years ago

First merge

schanzer commented 7 months ago

@blerner I'm assuming that

  1. CPO has changed enough in the last half-decade that this PR is no longer usable, and
  2. That with Anchor coming down the pike, this will also soon be moot.

OK to close?

blerner commented 7 months ago

I've never seen this code before. I don't know what it is intended to do...

jpolitz commented 7 months ago

This was a great idea at the time. It will be superseded by other save-to-localstorage/indexedDB solutions before we can make use of it, though.

jpolitz commented 7 months ago

(This was actually really great work that went a little beyond just local file saving. It was an electron-hosted container for CPO for offline use.)

blerner commented 7 months ago

Well that does sound cool! 👍

jpolitz commented 7 months ago

Actually now I'm realizing it still has some good ideas. Looking at the diff is probably useful, and actually only package* conflict. It's kind of orthogonal to what's going on on the page. And since we have BrowserFS presumably we can swap in real node implementations of that API. Not a totally outlandish experiment to try and finish.