search

brownplt / code.pyret.org

Website for serving Pyret to folks.
Other
24 stars 45 forks source link

check dark mode with table row rendering #335

Closed shriram closed 4 years ago

shriram commented 4 years ago

I'm using Monokai in the browser extension, and this code

t = table: x, y
  row: 1, 2
  row: 3, 4
end

t.row-n(1)

produces this output: image Your eyes probably have to be a lot younger than mine to see the 3 and 4 in there!

blerner commented 4 years ago

@thomascastleman this seems to be something for you. I'll add that when I pull from your latest commit (https://github.com/brownplt/code.pyret.org/pull/332/commits/4c715a4fc1d86b5a3b18c47b251de349f8ca804c), I get some very odd "incomplete styles": if I start off in the default style and run Shriram's program above, I get image If i switch to Monokai, I get image For some reason, the background hasn't changed, but the REPL has. If I switch back to default I get the original image, and if I switch back to Monokai a second time, I get image

thomascastleman commented 4 years ago

If Shriram is using the original extension's highlighting (dark-pyret), that was a bug I patched but forgot to roll out on the Chrome store (oops). It shouldn't be an issue in the latest themes on my style-updates branch though, so Ben's case is concerning.

@blerner , I seem to be unable to reproduce the issue--which browser are you using? Also, could you inspect & watch the class on the body as you load the page/change themes to see what's happening there?

blerner commented 4 years ago

Ah, never mind, that's better: I had some stale build state. After rebuilding, I get a cleaner appearance: image Closing this issue as fixed in the PR, but there is a lingering issue that I'll comment on there.