search

brownplt / code.pyret.org

Website for serving Pyret to folks.
Other
24 stars 45 forks source link

prevent scrollbars from causing REPL line height issues #383

Closed thomascastleman closed 3 years ago

thomascastleman commented 3 years ago

This addresses the line height problems mentioned in #377 by changing scrollbars in the non-default themes.

Previously, they used the ::webkit-scrollbar selectors to create a custom scrollbar for both the REPL and CodeMirror windows. We've switched to using the color-scheme property, which is only affecting the color of the scrollbar and seems reasonably well-supported.

We have checked Firefox, Brave, Chrome and Safari and so far the worst effect is that in Safari when switching between themes, the scrollbar maintains its previous color until you click on it. I would argue this is a better issue than line height problems that prevent the REPL from being readable.

jpolitz commented 3 years ago

Agreed that this is an improvement, thanks!