fix table borders in Firefox

brownplt / code.pyret.org

Website for serving Pyret to folks.

Other

24 stars 45 forks source link

fix table borders in Firefox #406

Closed thomascastleman closed 5 months ago

thomascastleman commented 3 years ago

For whatever reason tables have a rectangular border in Firefox.

with-border

I only noticed because I accidentally set the table border to be black for the default theme. This PR removes that border so that tables are consistent across browsers, but still allows themes to control the internal borders between table cells.

blerner commented 2 years ago

Are the package-lock.json changes necessary for this PR? If not, remove them...

I'm not sure whether we want this change exactly this way, or not -- my initial aesthetic reaction was "hmm, I think I do want a border, but I want it to match the rounded corners of the table..." @jpolitz or others, thoughts?

blerner commented 5 months ago

Closing this PR, since there's a cleaner (1-line!) CSS fix to make the borders hug the table more tightly. This will also give tight borders to rendered rows.