search

brownplt / code.pyret.org

Website for serving Pyret to folks.
Other
24 stars 45 forks source link

Smaller sbc continuation #421

Closed JohnUUU closed 2 years ago

JohnUUU commented 2 years ago

This is a smaller Pull Request with just the colors method and sort methods implemented for pie charts. Also includes small adjustments talked about earlier like having an actual enumerated StackType and having colors be connected to the data rather than the index.

jpolitz commented 2 years ago

We think this code looks pretty good – do you have a sense of what we should do to test it/mark it as complete @JohnUUU ?

JohnUUU commented 2 years ago

Thanks, most of the edge case tests I could think up of I've put in bar-chart-test.arr and I've done most of the pairwise combination tests for these graphs already. But those 2 approaches are the only real main approaches to testing I've done for these so if there's anything else that's Important to test for before marking it as complete I would do that! Otherwise if it seems well tested enough and works for your purposes easily enough then I think it would be fine to mark it as complete!