search

brownplt / code.pyret.org

Website for serving Pyret to folks.
Other
24 stars 45 forks source link

Modal popup can be moved so that the close button is inaccessible #470

Closed schanzer closed 9 months ago

schanzer commented 1 year ago
image

We had a teacher get totally stuck and flustered when she couldn't get the x back. jQuery has about a million settings for stuff like this -- is there any setting to disallow moving the modal off the left-hand and top edge of the screen?

schanzer commented 1 year ago

This destroyed me in PD today. If you zoom in (to show people a chart more closely), and then zoom out, some state in jquery gets is screwed up to the point where all new pop-ups will appear off screen. And I don't just been a little off screen -- I mean so far off screen that you can't see them, move them, or close them.

If there's a sequence of important things in the interactions area, refreshing is not an option - So all charts are useless.

asolove commented 1 year ago

@schanzer can you send me a set of steps to reproduce this? I can't tell what model you're in from that screenshot. And the one I tried (insert image) seemed to be ok post-zoom.

schanzer commented 1 year ago

@asolove !! thanks for looking into this. It took me a few minutes to remember the sequence that replicated it.

  1. I was only able to replicate this in Firefox, though I could have sworn the teachers in July were using chrome...
  2. Load a pyret file (this is the one I used), and click Run.
  3. Generate a chart in the interactions area (pie-chart(animals-table, "species")). It opens in a sensible location!
  4. Close the chart, then zoom in using a pinch gesture (NOT cmd +!!). Zoom out using a keyboard shortcut (cmd -!) so that everything appears to have gone back to the same size
  5. Regenerate the same chart. It opens off the edge of the screen! Sometimes you can even get it to hide the entire drag bar!
schanzer commented 1 year ago

@asolove I haven't opened FF in a while, and after writing that I noticed that it was asking me to upgrade to a later version. It looks like I can't replicate the issue anymore in the latest release, so I'm wondering if this is something that was also broken on Chrome in July but has since been fixed.

We can likely close this.