search

brownplt / code.pyret.org

Website for serving Pyret to folks.
Other
24 stars 44 forks source link

[WIP] Share modal updates #494

Open asolove opened 8 months ago

asolove commented 8 months ago
schanzer commented 6 months ago

@asolove any chance we can close this out in the near future? It's super low-hanging fruit..

asolove commented 6 months ago

Happy to. Can you review the open questions and venture some opinions? I’ll have to load it back into my head but there isn’t much left here as I recall.

On Thu, Jan 11, 2024 at 12:13 PM Emmanuel Schanzer @.***> wrote:

@asolove https://github.com/asolove any chance we can close this out in the near future? It's super low-hanging fruit..

— Reply to this email directly, view it on GitHub https://github.com/brownplt/code.pyret.org/pull/494#issuecomment-1887604424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACCL6EJY7SXBRXQHSJPJLYOAMSLAVCNFSM6AAAAAA7BDAT2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBXGYYDINBSGQ . You are receiving this because you were mentioned.Message ID: @.***>

schanzer commented 6 months ago

Excuse my ignorance here - where are these questions?

asolove commented 6 months ago

Oh, sorry, there is a long discussion in another issue around further updates to the share sheet. But yeah, this small round of tweaks can just get merged shortly.

schanzer commented 6 months ago

Does this PR address all three checkboxes, above? Or just the one? If it's just one I think it's best to wait until we snag the others.