asolove
commented
4 months ago Started looking at this one, some notes so I don't forget when I come back to this:
-
The resolution of this will need to be over in
pyret-lang, which defines the statistics package. -
The interesting bit here is that the definitions are currently typed for numbers and the implementations depend on that for efficiency, so we'll need to:
- Convert all these methods to be generic or just add a second set of parallel methods for strings. (Do we want to allow over arbitrary types? I don't think Pyret has a notion of generic constraints, and we'd like to constrain this to things where equality is reasonable. I also don't think we want arbitrary mixed types.)
- convert the implementation of
group-and-count, which currently depends on the runtime helperraw_array_sort_numsto an alternative that will work for other types. (We probably still want to use the fast version for numbers, though?)
schanzer
blerner
In the Statistics package, modes throws an internal error when used with non-numeric data. At the very least, this should be a better error! But more importantly, modes are not restricted to numbers. (This has some implications for our treatment of the topic in Bootstrap:DS -- right now we give a falsely narrow definition simply because Pyret doesn't support the full definition)