search

brownplt / lambda-py

Other
58 stars 10 forks source link

constructing lists from dict does not follow spec #52

Closed mpmilano closed 11 years ago

mpmilano commented 11 years ago

Right now, constructing a list from a dictionary will get you a list of key,value pairs. It should only get you a list of keys.

This is the only remaining bug preventing the test locals-class.py from working.

jpolitz commented 11 years ago

This should just be a one-line change in dict.py --- change pair[1] to pair[1][0].

I'm off in writing land and don't want to deal w/regression testing right now, but this should be trivial to do.

On Sun, Mar 24, 2013 at 6:20 AM, Matthew Milano notifications@github.comwrote:

Right now, constructing a list from a dictionary will get you a list of key,value pairs. It should only get you a list of keys.

This is the only remaining bug preventing the test locals-class.py from working.

— Reply to this email directly or view it on GitHubhttps://github.com/brownplt/lambda-py/issues/52 .

amtriathlon commented 11 years ago

I've fixed the dict.list issue but, the locals-class.py test now is failing due to interactions with the new attribute lookup regime: locals() is reporting local variables of functions used in class and method initialization.

mpmilano commented 11 years ago

Locals is broken right now due to the merge. I'm trying to figure out what happened to it.

~matthew

On Sun, Mar 24, 2013 at 9:02 PM, Alejandro Martinez < notifications@github.com> wrote:

I've fixed the dict.list issue but, the locals-class.py test now is failing due to interactions with the new attribute lookup regime: locals() is reporting local variables of functions used in class and method initialization.

— Reply to this email directly or view it on GitHubhttps://github.com/brownplt/lambda-py/issues/52#issuecomment-15373634 .