search

brownplt / pyret-lang

The Pyret language.
Other
1.07k stars 110 forks source link

"this code is not in the editor" #1109

Closed shriram closed 7 years ago

shriram commented 7 years ago 
> .2

produces an error with a link that says image Mousing over this produces the really weird text, "this code is not in the editor".

I can understand why it prints this, but to a user it makes no sense. Why are you telling me where it's not? A negative statement is such a strange thing to present. At the very least it should say something positive like "this error comes from a previous interaction" or say "the interaction window" or something like that.

Related to that, what is "the editor"? I'm editing in the REPL too, right? We should consistently use "definitions" and "interactions", not random phrases.

blerner commented 7 years ago

Dupe of https://github.com/brownplt/code.pyret.org/issues/202.

jswrenn commented 7 years ago

As @blerner noted, seeing that message in this particular context was the result of a (now fixed) bug. There are still situations in which this alert will, correctly, appear; e.g., when the snippeted code is not anywhere in the definitions or interactions history. Which brings me to the actual complaint here:

Why are you telling me where it's not?

Because, unfortunately, we don't know much more about it. It might be visible in another tab, but it might not. It's just not in the current tab. The best solution may to remove the hyperlink styling on the srcloc altogether.

shriram commented 7 years ago

Removing the hyperlink is far better than this kind of confusing pop-up!

schanzer commented 4 years ago

@shriram I'm unable to reproduce this using any of the examples from this or the linked issues. OK to close?

shriram commented 4 years ago

It's already closed.