brownplt / pyret-lang

The Pyret language.
Other
1.07k stars 111 forks source link

Some small Anchor UI updates #1678

Closed asolove closed 1 year ago

asolove commented 1 year ago

Done in this PR

Preview

Before:

Before

After:

After

Some proposed next steps

Questions

CosineP commented 1 year ago

On theming: If you haven't already encountere this, Joe did some work on this, in index.css there are definitions for a compact and a normal mode, which are classes that are swapped out somewhere(?). So this could probably be extended to other themes?

jpolitz commented 1 year ago

This is great, sorry for the extended delay. Merged. Responses to a few things below.

When you're in a nested folder, why does the option to navigate up a layer only show up in developer mode? I can see developer mode controlling if you can exit up above "projects", or whether the option is named ".." as opposed to some more user-friendly thing. But currently, when not in developer mode, you can create and navigate to a nested folder, but you can't then escape it (except by refreshing).

This should really be changed to what you describe, and not allow moving above the root.

A number of the programs on the Pyret homepage don't work out-of-the-box in either anchor or CPO. In particular, BinTree complains about missing annotations, print seems to error, and request doesn't seem to be easily-importable. Would folks be interested in an audit of which examples work where and possibly some suggested updates?

Thanks, added issue on the other repo. request has always been a bit of a lie, that might be worth updating as well.