search

brownplt / pyret-lang

The Pyret language.
Other
1.07k stars 110 forks source link

newline in URL renders as space, confusing #1722

Closed shriram closed 5 months ago

shriram commented 10 months ago

image

The space is easy to miss, and more to the point, isn't a newline, which made it hard for the student to find the error (and needed a TA to help).

Also a bit unclear why this is raising an exception and returning undefined instead of failing a bit more gracefully… Note that this also exposes the downloadImg URL.

blerner commented 5 months ago

This is rather hard to fix. Pretty much every UI suggestion you can make here won't work in the general case (show a weird inserted glyph? prevent line-breaking altogether? have runtime error in your run-on-url function somehow?)

As for the unable-to-load error showing undefined: we're trying to show the message field from the JS error that we get from that broken url, and apparently that error object doesn't have a message field -- in fact, it doesn't provide any useful information whatsoever in this case.

blerner commented 5 months ago

Btw, the current error message here is improved (as of https://github.com/brownplt/code.pyret.org/commit/317cc82b0da11be564c3c91687c4148c52026744), so I'm closing this issue: image