brownplt / pyret-lang

The Pyret language.
Other
1.06k stars 106 forks source link

Examplar improvements #1727

Open ds26gte opened 4 months ago

ds26gte commented 4 months ago

https://github.com/brownplt/pyret-lang/assets/3708729/46defce1-2a23-4fbb-86ef-9466da1ffbe4

schanzer commented 4 months ago

@schanzer tagging myself so I can stay up to date on this

ds26gte commented 4 months ago

Update: I was very surprised to see the red box during the call, but it's actually correct. I had forgotten I put in an empty placeholder file fact-code.arr alongside test.arr that had an empty definition for fact, waiting for the user to fill it in. So it is expected that the red box for test.arr should show all errors. Here's the screenshot with a valid definition inside fact-code.arr.

anchor-better

shriram commented 4 months ago

The main issue then is to avoid confusion between feedback from the reference implementation and from the student's implementation. They mean very different things. I'm going to add this as a todo item to your list at the top so that we remember to audit for this once you have fixed various issues.