search

brownplt / pyret-lang

The Pyret language.
Other
1.06k stars 106 forks source link

Reword error messages to avoid the use of "identifier", #1729

Closed blerner closed 2 months ago

blerner commented 3 months ago

while also not conflating mutable and immutable "variables"..

blerner commented 3 months ago

This PR should fix #1716 .

blerner commented 3 months ago

I'm torn on that suggestion -- the downsides of it being wrong (and causing the student to lose whatever experimentation in the REPL they had) seem much worse than the upside of getting it right ("wow how did you guess I hadn't done that in a while?!")

schanzer commented 3 months ago

With Pyret's REPL history in place, this doesn't seem like such a destructive thing to me, but I won't fight you on this. :)

schanzer commented 3 months ago

@jpolitz the wording change Ben makes here ("name" instead of "identifier") has the blessing of the entire curriculum team. Can this be merged in the next few weeks?