search

brownplt / pyret-lang

The Pyret language.
Other
1.06k stars 106 forks source link

Remove the version part of share URLs #558

Open sorawee opened 8 years ago

sorawee commented 8 years ago

https://code.pyret.org/editor#share=0ByoU3bgU-7hUbWstbHRFNTY1dGc&v=v0.5r697

The error on the console is:

https://code.pyret.org/trove/repl.js Failed to load resource: the server responded with a status of 404 (Not Found)
require.js:141 Uncaught Error: Script error for: trove/repl
http://requirejs.org/docs/errors.html#scripterror
https://code.pyret.org/compiler/compile-lib.arr.js Failed to load resource: the server responded with a status of 404 (Not Found)
require.js:141 Uncaught Error: Script error for: compiler/compile-lib.arr
http://requirejs.org/docs/errors.html#scripterror
https://code.pyret.org/compiler/locators/builtin.arr.js Failed to load resource: the server responded with a status of 404 (Not Found)
require.js:141 Uncaught Error: Script error for: compiler/locators/builtin.arr
http://requirejs.org/docs/errors.html#scripterror

The animation (rotating bones) just keeps playing, but the file is not loaded. It happens to only this file as far as I can see.

jpolitz commented 8 years ago

Thanks. The problem is that the Share URL has a very old version in it, and that's causing an issue.

I wonder if we should just remove the version part of share URLs by default. It causes more annoyance than good IMO, because it's not been feasible to always maintain backwards compatibility across versions.

On Fri, Sep 4, 2015 at 12:19 PM, sorawee notifications@github.com wrote:

https://code.pyret.org/editor#share=0ByoU3bgU-7hUbWstbHRFNTY1dGc&v=v0.5r697

The error on the console is:

https://code.pyret.org/trove/repl.js Failed to load resource: the server responded with a status of 404 (Not Found) require.js:141 Uncaught Error: Script error for: trove/replhttp://requirejs.org/docs/errors.html#scripterrorhttps://code.pyret.org/compiler/compile-lib.arr.js Failed to load resource: the server responded with a status of 404 (Not Found) require.js:141 Uncaught Error: Script error for: compiler/compile-lib.arrhttp://requirejs.org/docs/errors.html#scripterrorhttps://code.pyret.org/compiler/locators/builtin.arr.js Failed to load resource: the server responded with a status of 404 (Not Found) require.js:141 Uncaught Error: Script error for: compiler/locators/builtin.arrhttp://requirejs.org/docs/errors.html#scripterror

— Reply to this email directly or view it on GitHub https://github.com/brownplt/pyret-lang/issues/558.

jpolitz commented 8 years ago

(Try https://code.pyret.org/editor#share=0ByoU3bgU-7hUbWstbHRFNTY1dGc https://code.pyret.org/editor#share=0ByoU3bgU-7hUbWstbHRFNTY1dGc&v=v0.5r697 instead)

On Fri, Sep 4, 2015 at 12:21 PM, Joe Gibbs Politz joe@cs.brown.edu wrote:

Thanks. The problem is that the Share URL has a very old version in it, and that's causing an issue.

I wonder if we should just remove the version part of share URLs by default. It causes more annoyance than good IMO, because it's not been feasible to always maintain backwards compatibility across versions.

On Fri, Sep 4, 2015 at 12:19 PM, sorawee notifications@github.com wrote:

https://code.pyret.org/editor#share=0ByoU3bgU-7hUbWstbHRFNTY1dGc&v=v0.5r697

The error on the console is:

https://code.pyret.org/trove/repl.js Failed to load resource: the server responded with a status of 404 (Not Found) require.js:141 Uncaught Error: Script error for: trove/replhttp://requirejs.org/docs/errors.html#scripterrorhttps://code.pyret.org/compiler/compile-lib.arr.js Failed to load resource: the server responded with a status of 404 (Not Found) require.js:141 Uncaught Error: Script error for: compiler/compile-lib.arrhttp://requirejs.org/docs/errors.html#scripterrorhttps://code.pyret.org/compiler/locators/builtin.arr.js Failed to load resource: the server responded with a status of 404 (Not Found) require.js:141 Uncaught Error: Script error for: compiler/locators/builtin.arrhttp://requirejs.org/docs/errors.html#scripterror

— Reply to this email directly or view it on GitHub https://github.com/brownplt/pyret-lang/issues/558.

schanzer commented 7 years ago

Do we still want to remove the version part? I'm guessing more of the language and APIs have stabilized since this issue was opened...