browscap / browscap-site

Website for the Browser Capabilities Project
http://browscap.org/
2 stars 2 forks source link

Use ocramius/package-versions and use "proper" versions for build numbers #40

Closed asgrim closed 6 years ago

asgrim commented 6 years ago

May be able to use ocramius/package-versions to determine what the package version of browscap/browscap requested is, and generate the build number properly. Would mean using a proper version number though, I'm thinking perhaps we form it from the current one i.e. next is 6029 so would be come 6.0.29. That way we can track BC breaks in browscap/browscap by bumping major version, and each patch version can simply be the new build release (means we can also drop the stupid BUILD_NUMBER textfile!)

Then in composer.json here (for the site) can just do "browscap/browscap": "6.0.29" and that would translate to 6029. Note the "minor" version we'd drop, it doesn't count to the middle version, so example translations:

Otherwise we limit ourselves to 99 builds per minor, this way we have 999 builds at least.

Or alternatively, we make the build number get really big next version and use 3 digits for each major/minor/patch version:

The latter might be more flexible actually.

Finally, the other approach is to drop the build number entirely, and just use the version as major/minor/patch as-is, though this might break lots of stuff that depend on the "build number" concept...

asgrim commented 6 years ago

@mimmi20 @jaydiablo feedback welcome here ^^^

mimmi20 commented 6 years ago

I would prefer the last version (with dropped build number). Because this would cause the most drouble, the second version is good too.