servo+browser.html - entering an url in the url bar doesn't seem to work after navigating a page

browserhtml / browserhtml

Experimental Servo browser built in HTML

Other

2.61k stars 160 forks source link

servo+browser.html - entering an url in the url bar doesn't seem to work after navigating a page #949

Closed nical closed 8 years ago

nical commented 8 years ago

Not sure whether it belongs to servo or browser.html. On a local build of today's servo on Linux:

1) ./mach run --release -w -b 2) enter reddit.com/r/rust in the url bar and press enter 3) visit a link from the reddit page 4) enter reddit.com/r/rust again in the url bar 5) nothing happens

paulrouget commented 8 years ago

Yeah. Most likely https://github.com/browserhtml/browserhtml/pull/948

Gozala commented 8 years ago

This is not fixed by #948 as far as I can tell.

Gozala commented 8 years ago

Ok, it seems to be related to the VirtualDOM stuff. Problem is we do not touch 'src' when location changes, because if did that would cause a page load. So what happens is that we change src back to what it was, then when VirtualDOM does diff / patch it can see that src attribute hasn't changed so it does not setAttribute('src', url) and there for load does not occur.

I need to think about this problem, but I'm going to submit a patch to fix this on way or another.