search

browserify / common-shakeify

browserify tree shaking plugin using `common-shake`
https://www.npmjs.com/package/common-shakeify
MIT License
105 stars 18 forks source link

Use @goto-bus-stop/common-shake #14

Closed goto-bus-stop closed 6 years ago

goto-bus-stop commented 6 years ago

This fork includes a PR to track dependent uses. That means that, if an export is used exclusively in unused functions, it will also get removed.

This is especially helpful for things like util and path, which have a lot of interdependent functions that could previously not be removed. For example, util.format was always included because it is used in other functions in the util module, even if the only thing the bundle used was util.inherits.

toddself commented 6 years ago

This fixes #12 for us. Is there a plan for getting this merged in?

goto-bus-stop commented 6 years ago

noted; surprised that this helps with that issue :D will release in a bit

toddself commented 6 years ago

Yeah, I figured might as well check out the open PR and re-run our build. We ended up forking and fixing sbd so this much lower priority for us, but nice to know there is a potential solution! Thanks as ever for your hard work!

On Fri, Apr 27, 2018, at 01:08, Renée Kooi wrote:

noted; surprised that this helps with that issue :D will release in a bit> — You are receiving this because you commented. Reply to this email directly, view it on GitHub[1], or mute the thread[2].>

Links:

  1. https://github.com/browserify/common-shakeify/pull/14#issuecomment-384897958
  2. https://github.com/notifications/unsubscribe-auth/AALzhKN7gpRUNOb148iqegqYOye6Zo7Yks5tstIKgaJpZM4TPy20
goto-bus-stop commented 6 years ago

:package: 0.5.0