search

browserify / commonjs-assert

Node.js's require('assert') for all engines
MIT License
293 stars 57 forks source link

deepStrictEqual #17

Closed calvinmetcalf closed 8 years ago

calvinmetcalf commented 8 years ago

this adds assert.deepStrictEqual which does exactly what you'd think it would do

defunctzombie commented 8 years ago

Is this part of the upstream node assert module?

calvinmetcalf commented 8 years ago

yes, would it make more sense to just bring in the current assert module ?

calvinmetcalf commented 8 years ago

ok rebased it based on current node, from what I can tell some of the things changed, e.g. the message formatting, I will comment on the changes individually

defunctzombie commented 8 years ago

Can we remove the commented out tests? Or should they be fixed?

calvinmetcalf commented 8 years ago

removed, we also should probably make the running of the node version of the test optional or based on a flag as it will fail in older nodes (due to the api changing)

On Mon, May 9, 2016 at 10:14 PM Roman Shtylman notifications@github.com wrote:

Can we remove the commented out tests? Or should they be fixed?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/defunctzombie/commonjs-assert/pull/17#issuecomment-218041977

calvinmetcalf commented 8 years ago

@defunctzombie ok should be fixed, it's still failing because I can't run the saucelabs tests from my repo, should pass if you fork it to your own repo and rerun it

calvinmetcalf commented 8 years ago

closing in favor of #18