search

browserify / commonjs-assert

Node.js's require('assert') for all engines
MIT License
293 stars 57 forks source link

assert 1.4.0 buffer problem #20

Closed joenoon closed 7 years ago

joenoon commented 8 years ago

Just noticed this from another project that was locked to assert@^1.3.0 (which pulled in 1.4.0 just now):

"Unable to resolve module buffer ..." - this is a react-native packager error, so not sure what other environments might be affected. But it looks like assert now requires something that may not be available across various environments (node, browser, rn, etc): https://github.com/defunctzombie/commonjs-assert/compare/cc3c9...master

Or for some reason that buffer-shims dependency isn't enough. I'm still looking into this and trying to figure out the best way forward. My guess is I should lock my project to "1.3.0" for now. Just wanted to open this issue in case others run into it.

calvinmetcalf commented 8 years ago

So it looks like you aren't using this in browserify or Webpack or somewhere else that provides buffer

On Wed, May 18, 2016, 5:02 PM Joe Noon notifications@github.com wrote:

Just noticed this from another project that was locked to assert@^1.3.0 (which pulled in 1.4.0 just now):

"Unable to resolve module buffer ..." - this is a react-native packager error, so not sure what other environments might be affected. But it looks like assert now requires something that may not be available across various environments (node, browser, rn, etc): cc3c9...master https://github.com/defunctzombie/commonjs-assert/compare/cc3c9...master

Or for some reason that buffer-shims dependency isn't enough. I'm still looking into this and trying to figure out the best way forward. My guess is I should lock my project to "1.3.0" for now. Just wanted to open this issue in case others run into it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/defunctzombie/commonjs-assert/issues/20

joenoon commented 8 years ago

Right, react-native has its own packager, so I guess it doesn't have buffer. It sounds like we found a way forward in the other project, so feel free to close - it doesn't look like others are having issues.