Added test cases for assert.fail and implemented corresponding changes

browserify / commonjs-assert

Node.js's require('assert') for all engines

MIT License

293 stars 57 forks source link

Added test cases for assert.fail and implemented corresponding changes #35

Closed don01001000 closed 5 years ago

don01001000 commented 6 years ago

It seems to me based on the documentation that assert.fail(message) should throw an exception for which the message property is just the message passed in. However, it's being set to whatever message is wrapped in single quotes and followed by undefined undefined.

See #34.

BridgeAR commented 5 years ago

Sorry that this has not been looked at earlier. It seems like it's superseded by #44 now. @goto-bus-stop @lukechilds

BridgeAR commented 5 years ago

Closing since #44 landed. @don01001000 thanks a lot for your contribution and sorry that this could not land!