search

browserify / commonjs-assert

Node.js's require('assert') for all engines
MIT License
293 stars 57 forks source link

Strict mode? #37

Closed jprichardson closed 5 years ago

jprichardson commented 5 years ago

Node v9.9.0 introduced some changes into the assert package. Most notably the introduction of strict mode.

Would you accept a PR introducing this new functionality and bringing this module up to date?

jprichardson commented 5 years ago

If it simplifies the maintenance burden on your end @defunctzombie - how would you feel about moving this repo to the browserify org?

defunctzombie commented 5 years ago

@jprichardson I'd be open to that (clearly I have let this module go by the wayside) - what would that require logistically?

calvinmetcalf commented 5 years ago

I think you'd have to grant ownership of the project to somebody who is an admin in the browserify org, which would include both me and @jprichardson

defunctzombie commented 5 years ago

@calvinmetcalf you are already listed as a collaborator on the repo - is there some other action that "grants ownership" ?

calvinmetcalf commented 5 years ago

i just invited you into the browserify org

defunctzombie commented 5 years ago

@calvinmetcalf Should I see a notification somewhere for that? I received no email about it.

jprichardson commented 5 years ago

I tried to invite you again @defunctzombie. Looks like you were invited by Substack awhile ago. See if you can visit this link: https://github.com/organizations/browserify/settings/profile and if there is something about accepting the invite.

defunctzombie commented 5 years ago

@jprichardson I get a 404 when I visit that link.

jprichardson commented 5 years ago

@defunctzombie I canceled the invite, and then invited you again. Any email now...?

defunctzombie commented 5 years ago

@jprichardson @calvinmetcalf repository transferred. Feel free to remove me from the browserify organization.

kuraga commented 5 years ago

Wow! I've come here at the right moment... :smile: :+1:

kuraga commented 5 years ago

@jprichardson It would be very nice if we'll get a NodeJS-compatibility. I.e. commonjs-assert x.y is compatible with NodeJS x.y!

fabiosantoscode commented 5 years ago

Any updates on this issue?