search

browserify / createHash

Node style hashes for use in the browser, with native hash functions in node
MIT License
52 stars 34 forks source link

current npm version 1.1.2 of package create-hash does not support md5 stream calcualtion #15

Closed XiaoningLiu closed 7 years ago

XiaoningLiu commented 7 years ago

Hi,

For package create-hash, current npm version 1.1.2 doesn't support md5 calculation based on stream.

We need buffer all the data in memory and then calculate the md5. It's not possible for calculating md5 of huge files.

@fanatid had created the md5.js module based on stream. There is also a branch named feature/update-hashes.

It's possible to update the npm version based on this branch?

I'm also willing to help during the update.

Best, Xiaoning

calvinmetcalf commented 7 years ago

I'm on vacation but can take a look next week

On Tue, Oct 18, 2016, 12:58 PM XiaoningLiu notifications@github.com wrote:

Hi,

For package create-hash, current npm version 1.1.2 doesn't support md5 calculation based on stream.

We need buffer all the data in memory and then calculate the md5. It's not possible for calculating md5 of huge files.

@fanatid https://github.com/fanatid had created the md5.js module based on stream. There is also a branch named feature/update-hashes.

It's possible to update the npm version based on this branch?

I'm also willing to help during the update.

Best, Xiaoning

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/crypto-browserify/createHash/issues/15, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n75ChhtRK5EeEpBqPFhD4Zl81ELfks5q1Jg3gaJpZM4KZmG3 .

XiaoningLiu commented 7 years ago

Great thanks!

dcousens commented 7 years ago

Closing in favour of https://github.com/crypto-browserify/createHash/pull/19, related to https://github.com/crypto-browserify/createHash/issues/11