search

browserify / createHash

Node style hashes for use in the browser, with native hash functions in node
MIT License
52 stars 34 forks source link

Add React Native support #16

Closed 39otrebla closed 7 years ago

calvinmetcalf commented 7 years ago

I don't know if it makes sense for this library to globally shim buffer

On Sat, Mar 4, 2017, 11:48 AM dRand notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/crypto-browserify/createHash/pull/16 Commit Summary

  • Add React Native support

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/crypto-browserify/createHash/pull/16, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4nwgDev3u57Pb882YvIl8a9GQbM9Hks5riZXfgaJpZM4MTI3Q .

dcousens commented 7 years ago

Relevant https://github.com/bitcoinjs/bitcoinjs-lib/issues/582#issuecomment-280561453

dcousens commented 7 years ago

@39otrebla did you complain to react-native? Many others have had this same issue, and we can't resolve it by patching every dependency - just for react-native :(

39otrebla commented 7 years ago

thank you for you interest @dcousens . I found the solution. It is neither a createHash nor a react-native problem. Indeed, was really strange that shimming Buffer was raising problems only with this module (I have >10 crypto-dependencies in my project, and all of them require Buffer in some way). So I haven't opened an issue on react-native, and I closed this one. Sorry for the time spent on this.