search

browserify / crypto-browserify

partial implementation of node's `crypto` for the browser
MIT License
653 stars 199 forks source link

Added generateKeyPair #186

Open m00nwtchr opened 5 years ago

m00nwtchr commented 5 years ago

Added an implementation of generateKeyPair using the WebCryptoAPI

calvinmetcalf commented 5 years ago

tests?

m00nwtchr commented 5 years ago

How do i create tests if key gen is randomized?

mahnunchik commented 4 years ago

Any news?

calvinmetcalf commented 4 years ago

@lmarianski could you add a test that makes sure that the outputs of this are valid inputs

m00nwtchr commented 4 years ago

Oh yeah i forgot about this, i'll try to put something together, any ideas on what would the test actually entail? (besides the actual key generation, to make sure all is working)

m00nwtchr commented 4 years ago

Also, any ideas as to why it's freaking out about the template string I use in my package?

m00nwtchr commented 4 years ago

Anyways, added some tests, hope those will do, let me know if I should add anything else, and btw the whole test suite does pass for me locally (maybe its due to the travis script using older nodejs versions?)

calvinmetcalf commented 4 years ago

ok great will take a look

calvinmetcalf commented 4 years ago

we need to bump the node version in the .travis file, maybe to 10 or 12, I forget which is currently stable

On Fri, Jul 31, 2020 at 3:48 PM Łukasz Mariański notifications@github.com wrote:

Anyways, added some tests, hope those will do, let me know if I should add anything else, and btw the whole test suite does pass for me locally

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/crypto-browserify/crypto-browserify/pull/186#issuecomment-667321068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAITRH6H4N5PFYXTZMD4X63R6MNYDANCNFSM4IKCS5HQ .

-- -Calvin W. Metcalf

m00nwtchr commented 4 years ago

Do i just bump all the node versions in that file to LTS (v12)?

calvinmetcalf commented 4 years ago

yes please

Raktim123 commented 4 years ago

I'm waiting for this feature. When this feature would be available? 🙋🙋🙋

calvinmetcalf commented 4 years ago

checks need to pass first

calvinmetcalf commented 4 years ago

actually @lmarianski you need to avoid requring crypto and instead require the specific libraries you need, what you need to do here is make 2 versions, one for node one for the browser and have a switch in the package.json

jimblackler commented 2 years ago

Any news?

vstyler96 commented 2 years ago

Any news?

edilsalvador commented 1 year ago

Any news?