search

browserify / crypto-browserify

partial implementation of node's `crypto` for the browser
MIT License
653 stars 199 forks source link

buffer upgrades #187

Open calvinmetcalf opened 4 years ago

calvinmetcalf commented 4 years ago

seems like we're going to need to upgrade bn.js to deal with buffer depreciations see crypto-browserify/publicEncrypt#20 crypto-browserify/createECDH#13 crypto-browserify/browserify-sign#45 and crypto-browserify/diffie-hellman#31# which will all need to be upgraded in sync in order to make sure they all use the same major version of bn one

fanatid commented 4 years ago

Initial issue in elliptic repo: https://github.com/indutny/elliptic/issues/191

rawr51919 commented 3 years ago

This should be fixed in #200 because we switched to Buffer.from() there, but I'd like input on this. The others can also be easily fixed, or are already fixed. The only thing keeping all these from being officially fixed is for https://github.com/crypto-browserify/diffie-hellman/pull/31 to have bn.js updated. May be thinking of superseding it due to inactivity though.

rawr51919 commented 3 years ago

A dependency updater like Depfu would be nice to have to keep dependencies like bn.js updated so that way we don't have to worry about keeping them in sync, because that'll do it for us. It's probably something for another issue, though