search

browserify / crypto-browserify

partial implementation of node's `crypto` for the browser
MIT License
653 stars 199 forks source link

Fix Travis CI builds, update dependencies, and update list of as-yet unimplemented functions #200

Closed rawr51919 closed 1 year ago

rawr51919 commented 3 years ago

Fixes #199 Fixes #196 Fixes #194 Fixes #192

rawr51919 commented 3 years ago

Minor note @ljharb Node 0.1x builds broke because https://github.com/crypto-browserify/publicEncrypt grabs a later version of parse-asn1 than what was originally used for the last build 3 years ago. This later version is incompatible with node 0.1x due to erroring on the unit tests there.

ljharb commented 3 years ago

0.1? Or 0.10?

rawr51919 commented 3 years ago

0.1? Or 0.10?

0.11/0.12

rawr51919 commented 3 years ago

@ljharb I figured out what was erroring out the build originally for Saucelabs. Some of the ports weren't forwarded for some strange reason

Error: connection refused: localtunnel.me:41870 (check your firewall settings)
Error: connection refused: localtunnel.me:34242 (check your firewall settings)
Error: connection refused: localtunnel.me:35354 (check your firewall settings)

These are from the last build from 3 years ago. Perhaps trying to fix these would be worth your while

ljharb commented 3 years ago

gotcha, but they’ll pass now? If not, can we pin parse-asn1 so they do?

rawr51919 commented 3 years ago

gotcha, but they’ll pass now?

If of course you have those issues fixed, then yes, this will just fine (see my last few posts here for what issues I'm talking about)

rawr51919 commented 3 years ago

Pretty much, if the parse-asn1 issue is fixed along with those connection refused issues, this will pass Travis CI

rawr51919 commented 3 years ago

gotcha, but they’ll pass now? If not, can we pin parse-asn1 so they do?

Yep! 5.1.0 iirc is the last version that worked

rawr51919 commented 3 years ago

Any progress updates on this so far? Has the Saucelabs stuff been figured out yet?

rawr51919 commented 3 years ago

Looks like this fixes more than I first realized.

cwc972135903 commented 2 years ago

do you how to implement the generateKeyPair

rawr51919 commented 1 year ago

this PR will return, eventually, just was cleaning out old repos, may merge this and #201 together into one PR