search

browserify / detective

Find all calls to require() no matter how deeply nested using a proper walk of the AST
Other
414 stars 61 forks source link

Support require statements in code with ES6 syntax #28

Closed joakimbeng closed 10 years ago

joakimbeng commented 10 years ago

Because the current version of node-detective uses the esprima module, and not the esprima-six module it crashes when it encounters ES6 specific syntax, e.g. stars in generator functions and the yield keyword.

It would be great if this could be added! :)

ghost commented 10 years ago

Very noisy diff, please tune down your editor!

ghost commented 10 years ago

Merged in 2.4.0. There are some more places that browserify walks the AST, so it will require changes to some other modules too before es6 completely works in browserify.

joakimbeng commented 10 years ago

Sorry about the noisy diff, will think about that next time..

Yeah, I've noticed that. I think syntax-error needs to be changed as well.