browserify / detective

Find all calls to require() no matter how deeply nested using a proper walk of the AST
Other
414 stars 60 forks source link

Update Travis CI tests to use newer Node.js versions #43

Closed voxpelli closed 9 years ago

voxpelli commented 9 years ago

As the ^1.4.1 syntax used for currently including the escodegen module was first introduced in npm 1.3, the npm 1.2 verison included with node 0.8.x fails at installing the dependency.

The escodegen module itself also in version 1.3.3 changed from requiring node >=0.4.0 to requiring node >=0.10.0, so it explicitly doesn't support 0.8.x anymore either.

The pull request to update the required acorn dependency ran into this issue and since that very same PR preferably should use the caret operator for the dependency it would be better to stop testing in node 0.8.x and start testing in newer node versions instead.

Related PR: https://github.com/substack/node-detective/pull/41

zertosh commented 9 years ago

Thanks! Fixed by https://github.com/substack/node-detective/pull/46