browserify / detective

Find all calls to require() no matter how deeply nested using a proper walk of the AST
Other
414 stars 61 forks source link

update acorn version to better handle the object pattern #72

Closed AlexisTessier closed 6 years ago

AlexisTessier commented 6 years ago

Due to an error in the old version of acorn, it is impossible to use the key name "set" in a object pattern, like that :

function load2({set = 'hello'}) { return load('tt'); }

I just updated the acorn dependency.

I also added a test to check this specific use case but I'm not sure it's pertinent because the real issue is that the dependency was not up to date.

goto-bus-stop commented 6 years ago

thanks, this looks good! could you remove the package-lock file and use the ^ semver operator in the dependency, so we'll get future updates too?

AlexisTessier commented 6 years ago

Done in the last commit.

goto-bus-stop commented 6 years ago

perf, thanks!

goto-bus-stop commented 6 years ago

📦 4.6.0