search

browserify / diffie-hellman

pure js diffie-hellman
MIT License
95 stars 26 forks source link

browser: cleanup #11

Closed dcousens closed 9 years ago

dcousens commented 9 years ago

This still needs a lot of work. I still don't know exactly what this function is meant to be doing, I'll continue cleaning it up and review against the DH documentation.

WIP PR do not merge.

calvinmetcalf commented 9 years ago

I need to lint my code damn

calvinmetcalf commented 9 years ago

@dcousens ping on this?

dcousens commented 9 years ago

@calvinmetcalf still going, just had Australia day weekend away.

calvinmetcalf commented 9 years ago

@dcousens sorry missed your last comment, I added 2 more commits to this pull, one cleaned up the indentations, spaceing and the function names we use in dh.js and the second fixes an api bug where I wasn't returning this to allow chaining and I also gave returnValue a better name

dcousens commented 9 years ago

@calvinmetcalf we still have a lot to do, but I think this is a good first pass.

calvinmetcalf commented 9 years ago

ok I can publish