search

browserify / events

Node's event emitter for all engines.
MIT License
1.38k stars 173 forks source link

clean code EventEmitter #51

Closed behnammodi closed 6 years ago

behnammodi commented 6 years ago

split all method

goto-bus-stop commented 6 years ago

Thanks for the PR! This module copies the Node core EventEmitter code though; it's easier to do that when it's in a single file, like it is in Node.

behnammodi commented 6 years ago

I did it to keep the code up and so it's easier

goto-bus-stop commented 6 years ago

I think it's easier to apply updates if it's more similar to Node, because we can copy paste into the file and don't have to think about converting it to the modular structure.

behnammodi commented 6 years ago

@goto-bus-stop thank's