search

browserify / factor-bundle

factor browser-pack bundles into common shared bundles
Other
402 stars 27 forks source link

Missing dependency : through #14

Closed DjebbZ closed 10 years ago

DjebbZ commented 10 years ago

through is in the devDependencies but the index.js file of factor-bundle requires it on line 2. So npm install factor-bundle isn't installing it, and using it in the cli with browserify fails ("through module not found").

npm install browserify factor-bundle
npm run build

> test-browserify@0.0.0 build /home/djebbz/tmp/test-browserify
> browserify index.js index2.js -p [ factor-bundle -o build1.js -o build2.js ] -o common.js

module.js:340
    throw err;
          ^
Error: Cannot find module 'through'
DjebbZ commented 10 years ago

Problem confirmed : manually adding "through" in the package.json of factor-bundle and doing again npm install make the build work.