search

browserify / factor-bundle

factor browser-pack bundles into common shared bundles
Other
402 stars 27 forks source link

same gid in groups counts towards threshold #2

Closed terinjokes closed 10 years ago

terinjokes commented 10 years ago

In addGroups the same gid can be added multiple times to a group. This can cause the threshold check in _flush to fail.

terinjokes commented 10 years ago

I resolved this by uniquing the array in _flush (and now my modules looked to be factored correctly).

terinjokes commented 10 years ago

Creating a PR