browserify / factor-bundle

factor browser-pack bundles into common shared bundles
Other
402 stars 27 forks source link

factor bundle tries to read _basedir from browserify #30

Closed Pita closed 10 years ago

Pita commented 10 years ago

The code is here: https://github.com/substack/factor-bundle/blob/master/index.js#L36

There is no _basedir variable in the latest browserify version. Even if you pass a basedir option. This doesn't fail because it falls back to process.cwd(). process.cwd() doesn't do it in my case cause I'm bundling files in another directory

terinjokes commented 10 years ago

Ok, fixing.

Pita commented 10 years ago

that was quick, thx!