search

browserify / factor-bundle

factor browser-pack bundles into common shared bundles
Other
402 stars 27 forks source link

Grouped modules don't update dependencies when added to additional groups #4

Closed terinjokes closed 10 years ago

terinjokes commented 10 years ago

If a module (moduleA) is emitted by module-deps, it is transformed by this module. If it had already been added to a group, it matches the second if clause and it's children are added to the same groups.

It's possible for moduleA to be added to new groups after this, if it's a dependency of another module in another group, but this additional group isn't added to the dependencies. You could then end up with moduleA in the common output, but some of it's dependencies in a group.

ghost commented 10 years ago

I think this was also fixed and is in the unit tests. Please re-open if this is not the case!

terinjokes commented 10 years ago

This also isn't fixed, from what I can tell. Working on abstracting a failing test case. If you can reopen.

ghost commented 10 years ago

should be fixed now in 0.1.2.