search

browserify / factor-bundle

factor browser-pack bundles into common shared bundles
Other
402 stars 27 forks source link

Revert dedupe dependency handling #40

Closed jgoz closed 10 years ago

jgoz commented 10 years ago

The changes in substack/node-browserify#880 made the changes in #38 and #39 unnecessary, so I reverted them. They were arguably hacks around improper dependency specification that was resolved as of browserify@5.11.0.

For safety, I added a regression test for the missing dependency in deduped modules. It passes in >=5.11 and fails in <=5.10 with Error: Cannot find module '4' when executing common + c.

Sorry about the churn on this.

terinjokes commented 10 years ago

@substack since you merged the previous commits as 2.2.0, should I merge this as 2.3.0? The API didn't change for either of them, so it would seem they should be patches, but not sure exactly of your release schema, so I can't duplicate it.

ghost commented 10 years ago

A minor patch should be fine then. I wasn't too sure about the last round of patches so I played it safe and bumped the minor.

jgoz commented 10 years ago

@terinjokes Any chance you can merge & publish this today?

terinjokes commented 10 years ago

Merged as 2.2.1.

jgoz commented 10 years ago

Thanks!