search

browserify / factor-bundle

factor browser-pack bundles into common shared bundles
Other
400 stars 27 forks source link

Seems to have problems with npm linked dependencies #66

Open abritinthebay opened 9 years ago

abritinthebay commented 9 years ago

If I have in my my code say require("immutable") and in an npm linked module elsewhere on my system the same require code it gets treated as two different libraries when factored and doesn't end up in the common bundle.

It's odd, and it works fine when not using npm link. I can only assume it's something to do with the paths of those files being quite different (ie, when linked it's not in the normal dep tree of the core code).

Frustrating though, especially when dealing with applications that are developed locally with private modules as abstracted parts of the core app. It very much bloats the code.

terinjokes commented 9 years ago

You're probably right, I'll take a look.

abritinthebay commented 9 years ago

Thanks! Obviously I can work around it (unlinking before building bundles) but... less than ideal :)

abritinthebay commented 9 years ago

Update - this also causes lots of "fun" when using React - as it completely breaks React's refs for some reason.

This actually might be a browserify issue rather than a factor-bundle issue (just that it ends up screwing up factor-bundle too)