search

browserify / http-browserify

node's http module, but for the browser
MIT License
244 stars 110 forks source link

Support `res.setEncoding` and non-text response types #21

Open wmrowan opened 11 years ago

wmrowan commented 11 years ago

Response data in http-browserify seems to default to text. In node http it seems to default to buffer. Independent of defaults, the node version supports setEncoding so you can change the type of the response. The browserify version should do the same.

Jxck commented 9 years ago

+1 or support only setEncoding('utf8') and ignore others seems fine.

tellnes commented 9 years ago

See #10

MiguelCastillo commented 9 years ago

So, is there a plan to merge the PR?

jamestalmage commented 9 years ago

Would there be any value to throwing or at least logging an error if it is not utf-8?

+1 either way.

jstoeffler commented 8 years ago

+1

drawm commented 7 years ago

+1 Causes problem on other library. https://github.com/baalexander/node-xmlrpc/issues/135