search

browserify / http-browserify

node's http module, but for the browser
MIT License
244 stars 110 forks source link

Make `withCredentials` a param allowing caller to set #35

Closed derekr closed 10 years ago

derekr commented 10 years ago

Wasn't sure if there was a solid reason for forcing withCredentials to be true and thought it would be useful to make a param. I am working with a server that doesn't support the credentials header.

MaxGfeller commented 10 years ago

+1

I also run in trouble with the withCredentials automatically been set. If a resource has CORS enabled, then this is not possible with credentials flag set to true: Wildcards cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true.

After commenting out in my bundle.js it worked.

ghost commented 10 years ago

merged in 1.3.1.

feltnerm commented 9 years ago

Is this (forcing the user to override the defaults set via the spec) really the best solution? @substack , please look at #47.

Much :heart: for what you do @substack, thanks.