replace params.scheme with params.protocol

browserify / http-browserify

node's http module, but for the browser

MIT License

244 stars 110 forks source link

replace params.scheme with params.protocol #42

Open hendrikcech opened 10 years ago

hendrikcech commented 10 years ago

When passing an url string to https-browserify, a http request was send off. This commit simplifies the code and fixes that bug.

tmpvar commented 10 years ago

this looks like it actually complicates the code - what bug does this fix? Probably should add a test to exercise it

hendrikcech commented 10 years ago

It needs to be more complicate to be backwards compatible. This change is necessary to be consistent with the node api. It's also connected to this bug: substack/https-browserify#1.