search

browserify / http-browserify

node's http module, but for the browser
MIT License
244 stars 110 forks source link

`ClientRequest#setTimeout` Support #49

Open pvoisin opened 10 years ago

pvoisin commented 10 years ago

First time I'm using Browserify, first test, and I stumble on that... ;)

It currently doesn't seem to support setTimeout.

brandonrobertz commented 9 years ago

Is there any interest in pulling in a fix for this, if write a pull request? I've ran into a situation where the lack of setTimeout is breaking some libraries when they are Browserified. The maintainer of one library in particular would prefer an upstream fix and I'm willing to write it if there's interest.

dcousens commented 9 years ago

+1, would appreciate a fix for this as well

brandonrobertz commented 9 years ago

Just an update, I'm working on this and should have a PR for this issue this weekend.

brandonrobertz commented 9 years ago

Initial push on this. It's still just in my fork. I've verified that it works with my target library (https://github.com/freewil/node-bitcoin). Anyone else want to take a look?

https://github.com/brandonrobertz/http-browserify/compare/substack:master...master

brandonrobertz commented 9 years ago

https://github.com/substack/http-browserify/pull/80