search

browserify / randombytes

random bytes from browserify stand alone
MIT License
99 stars 47 forks source link

Buffer.from is not a function #9

Closed kjvalencik closed 7 years ago

kjvalencik commented 7 years ago

This commit introduced a regression in browsers that don't implement Buffer.from.

jprichardson commented 7 years ago

Please update your dependencies. safe-buffer provides a compatible shim for Buffer.from.

kjvalencik commented 7 years ago

Interesting. I see that. It might be that some part of the processing pipeline is removing the if statement based on the Node buffer implementation. safe-buffer has been trimmed to just module.exports = require('buffer') in the build.

calvinmetcalf commented 7 years ago

@kjvalencik that was the case until the most recent version of safe-buffer fixed that

calvinmetcalf commented 7 years ago

@kjvalencik that was the case until the most recent version of safe-buffer fixed that

kjvalencik commented 7 years ago

@calvinmetcalf Thanks. That is confirmed the issue. I bumped the version and it fixed it.

calvinmetcalf commented 7 years ago

published

calvinmetcalf commented 7 years ago

published v2.0.5