search

browserify / sha.js

Streamable SHA hashes in pure javascript
Other
288 stars 60 forks source link

Copyright to contributors #10

Closed dcousens closed 10 years ago

dcousens commented 10 years ago

As requested in #9, moved this to a separate PR.

The change is straight forward enough, thoughts?

edit: This is just a suggestion, and by no means blocks my other pull requests.

dominictarr commented 10 years ago

;) okay but you also need to give the reasons why you think this change should be made

dcousens commented 10 years ago

Contribution history is great, but this solidifies that notion of shared effort, in the license.

For example, say I wanted to use the SHA512 implementation (yet to be merged) I wrote in a separate project, but I happened to commit it here first, I would have to reference back to this project in its entirety (and include the copyright notice etc, aka follow the license).

Compare that to the opposite situation, where I would be able to keep the work I contributed as my copyright, without obligation to reference back to this project; unless of course, I used any other parts of this project that were not written by me of course.

edit: to be honest, I just felt it was more fair to credit where its due, and ownership over your own contributions seems fair.

dominictarr commented 10 years ago

okay, cool.