Fix issues in IE9 - Githubissues

parshap commented 10 years ago

Tests now pass in IE9 using testling. There were several issues:

Int32Array was used without a fallback, now this falls back to Array. We may want to use typedarray.Int32Array instead of a normal Array here, but Array was much faster (~3x faster tests).
UInt8Array was used in tests, now this uses the typedarray module. It may be better to use native typed arrays if available before falling back to typedarray.
console.error was used in tests. I changed these calls to console.log instead of providing an inline polyfill. This is not an issue for my use case because I already polyfill console.*, but I did this just to get tests running.

dominictarr commented 10 years ago

okay this is merged into 2.2.4

parshap commented 10 years ago

Hmm... I don't see 2.2.4 on Github - the latest commit is 2.2.3.

dominictarr commented 10 years ago

I added some more updates, and published 2.2.6

dominictarr commented 10 years ago

I added some more updates, and published 2.2.6

parshap commented 10 years ago

@dominictarr the latest commit in GitHub is still 2.2.3.

dominictarr commented 10 years ago

oh, oops. fixed now. I didn't realize i was on a different branch.

On Thu, Sep 18, 2014 at 1:38 PM, Parsha Pourkhomami < notifications@github.com> wrote:

@dominictarr https://github.com/dominictarr the latest commit in GitHub is still 2.2.3.

— Reply to this email directly or view it on GitHub https://github.com/dominictarr/sha.js/pull/11#issuecomment-56021984.

browserify / sha.js

Fix issues in IE9 #11