search

browserify / sha.js

Streamable SHA hashes in pure javascript
Other
288 stars 60 forks source link

add missing hashes, clean up code #14

Closed calvinmetcalf closed 9 years ago

calvinmetcalf commented 9 years ago

this pull does 2 things and can be broken up into 2 pulls if needed

  1. adds sha224 and ssh384
  2. cleans up the whole buffer factory setup and all of the hashes export themselves instead of a factory
dcousens commented 9 years ago

utACK on the SHA code diffs. I believe there was a specific reason to be using those injection functions though. @dominictarr?

dcousens commented 9 years ago

@calvinmetcalf I would suggest you split this PR up into two/three parts.

calvinmetcalf commented 9 years ago

the no white space diff I believe the injector dates from when the buffer in browserify was not as good

dcousens commented 9 years ago

Ah, I love that. Always forget to add it to the end of my diff URL's. In any case, change atomicity is really useful for review and to get things merged without cross contaminating any potential concerns.

dominictarr commented 9 years ago

Yeah the injector was so that I could test with node's Buffer and with @feross's buffer for browserify. We could remove that now.

this is merged into 2.3.0