Closed calvinmetcalf closed 9 years ago
utACK on the SHA code diffs. I believe there was a specific reason to be using those injection functions though. @dominictarr?
@calvinmetcalf I would suggest you split this PR up into two/three parts.
toLowerCase
to Alg
the no white space diff I believe the injector dates from when the buffer in browserify was not as good
Ah, I love that. Always forget to add it to the end of my diff URL's. In any case, change atomicity is really useful for review and to get things merged without cross contaminating any potential concerns.
Yeah the injector was so that I could test with node's Buffer and with @feross's buffer for browserify. We could remove that now.
this is merged into 2.3.0
this pull does 2 things and can be broken up into 2 pulls if needed